-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] Filter streams by subject #1062
Conversation
ac69f50
to
2a42858
Compare
js.go
Outdated
@@ -359,6 +361,17 @@ func DirectGetNext(subject string) JSOpt { | |||
}) | |||
} | |||
|
|||
// StreamListFilter is an option that can be used to configure `StreamsInfo()` and `StreamNames()` requests. | |||
// It allows filtering the retured streams by subject associated with each stream. | |||
// Wildcards can be used. For example, `StreamListFilter(FOO.>.A) will return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FOO.>.A
is an invalid subject I think, maybe switch to the asterisk wildcard variant:
// Wildcards can be used. For example, `StreamListFilter(FOO.>.A) will return | |
// Wildcards can be used. For example, `StreamListFilter(FOO.*.A) will return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that - fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #1061