Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Monitoring: Include subscriptions in Gatewayz #6525

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

kozlovic
Copy link
Member

When checking the gatewayz monitoring endpoint, if the user requests accounts ?accs=1 or a specific account ?acc_name=B then we can now include the subscription list for each account with &subs=1 or the subscription details list with &subs=detail.

The subscription information will be contained in each account in the accounts list of the outbound_gateways block.

Resolves #6473

Signed-off-by: Ivan Kozlovic ivan@synadia.com

When checking the `gatewayz` monitoring endpoint, if the user
requests accounts `?accs=1` or a specific account `?acc_name=B`
then we can now include the subscription list for each account
with `&subs=1` or the subscription details list with `&subs=detail`.

The subscription information will be contained in each account in
the `accounts` list of the `outbound_gateways` block.

Resolves #6473

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from a team as a code owner February 18, 2025 21:36
@kozlovic
Copy link
Member Author

@bruth Not sure if this is strictly a 2.11 or if it can go into the next release. I don't know if @alexbozhenko really needs this asap for some debugging use cases or not.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbozhenko
Copy link
Contributor

Thank you, @kozlovic! We do not need it asap, we can wait for 2.11

@derekcollison derekcollison merged commit 7ca0fe3 into main Feb 19, 2025
5 checks passed
@derekcollison derekcollison deleted the fix_6473 branch February 19, 2025 00:01
@wallyqs
Copy link
Member

wallyqs commented Feb 20, 2025

I think we should include in v2.10.26 this one, will be quite useful already

@wallyqs wallyqs changed the title (2.11) [ADDED] Monitoring: Include subscriptions in Gatewayz [ADDED] Monitoring: Include subscriptions in Gatewayz Feb 21, 2025
neilalexander added a commit that referenced this pull request Feb 21, 2025
Includes the following:

- #6524
- #6525
- #6526
- #5424
- #6565
- #6532

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include subscription information in gatewayz
4 participants