Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-flake by waiting for account fetch in (super) cluster #6329

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

MauriceVanVeen
Copy link
Member

Similar fix to #4533, but extending to some other clustered tests, as well as one super cluster test. Should prevent these tests from failing with JetStream not enabled for account.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner January 6, 2025 21:01
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit dae8c6c into main Jan 6, 2025
5 checks passed
@derekcollison derekcollison deleted the maurice/acc-js-not-enabled branch January 6, 2025 21:22
MauriceVanVeen pushed a commit that referenced this pull request Jan 9, 2025
Similar fix to #4533, but
extending to some other clustered tests, as well as one super cluster
test. Should prevent these tests from failing with `JetStream not
enabled for account`.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander added a commit that referenced this pull request Jan 9, 2025
Deponds on #6345

Includes the following de-flakes:
- #6329
- #6330
- #6331
- #6332
- #6334

And this data race fix:
- #6150

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
wallyqs added a commit that referenced this pull request Jan 9, 2025
#### Dependencies
- #6323
- #6324

####  Leafnode
- #6291

#### JetStream
- #6226
- #6235
- #6277
- #6279
- #6283
- #6289
- #6316
- #6317
- #6325
- #6326
- #6335
- #6338
- #6341
- #6344
- #6150
- #6351
- #6355

#### Tests
- #6278
- #6297
- #6300
- #6343
- #6329
- #6330
- #6331
- #6332
- #6334
- #6356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants