Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goroutine annotation for stream internal loop #5460

Merged
merged 1 commit into from
May 21, 2024
Merged

Add goroutine annotation for stream internal loop #5460

merged 1 commit into from
May 21, 2024

Conversation

neilalexander
Copy link
Member

This will improve observability on the mset.internalLoop() in profiles.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner May 21, 2024 15:58
derekcollison
derekcollison reviewed May 21, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that shutdown will wait on this now, we need to make sure that this does not adversely effect shutdown.

@neilalexander
Add goroutine annotation for stream internal loop
e3093ff 
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander
Copy link
Member Author

I think it would have been safe as that goroutine listens for qch and bails, but have instead switched it around to set the labels inline instead.

@derekcollison derekcollison self-requested a review May 21, 2024 16:06
derekcollison
derekcollison approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 6392242 into main May 21, 2024
4 checks passed
@derekcollison derekcollison deleted the neil/streamsendloop branch May 21, 2024 16:46
@wallyqs wallyqs mentioned this pull request May 21, 2024
Merged
wallyqs added a commit that referenced this pull request May 21, 2024
@wallyqs
Cherry-picks for 2.10.16 (#5462)
b918807 
Includes:

- #5460
- #5457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilalexander @derekcollison