[IMPROVED] MQTT error message when client connects with websocket #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Websocket is currently not supported for MQTT clients. When a client tries to connect with websocket protocol to the MQTT port, the error message: `mid:9 - not connected` would be logged, which is not really telling. The server will now guess if the connection was websocket and report a more appropriate error message, such as: ``` invalid connection, websocket currently not supported ``` Resolves #2126 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Websocket is currently not supported for MQTT clients. When a
client tries to connect with websocket protocol to the MQTT port,
the error message:
mid:9 - not connectedwould be logged, whichis not really telling.
The server will now guess if the connection was websocket and report
a more appropriate error message, such as:
Resolves #2126
Signed-off-by: Ivan Kozlovic ivan@synadia.com