General Updates and Stability Improvements #2131
Conversation
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
| @@ -2564,7 +2564,7 @@ func (n *raft) processAppendEntry(ae *appendEntry, sub *subscription) { | |||
| select { | |||
| case n.applyc <- &CommittedEntry{n.commit, ae.entries[:1]}: | |||
| default: | |||
| n.debug("Failed to place snapshot entry onto our apply channel") | |||
| n.warn("Failed to place snapshot entry onto our apply channel") | |||
There was a problem hiding this comment.
If i saw this, I would have no way to figure out what I could do about that. Is it just a wait and see kind of situation or what would be the remedy? Warn level logs need to be actionable some how - or indicate that they will hopefully clear
There was a problem hiding this comment.
I promoted it so it could be more easily reported to us via support channels etc.
| checkMirror(20) | ||
| } | ||
|
|
||
| func TestNoRaceJetStreamClusterSuperClusterRIPStress(t *testing.T) { |
server/stream.go
Outdated
| @@ -1352,7 +1386,7 @@ func (mset *stream) setupMirrorConsumer() error { | |||
| if ext != nil { | |||
| deliverSubject = strings.ReplaceAll(ext.DeliverPrefix+syncSubject(".M"), "..", ".") | |||
| } else { | |||
| deliverSubject = syncSubject("$JS.M") | |||
| deliverSubject = syncSubject("$JSDC.M") | |||
There was a problem hiding this comment.
Is that permanent or what is part of some debug/test?
There was a problem hiding this comment.
Tracking GW sub leaks I thought it was better to not be under the $JS.> envelope since ephemerals go away when they detect interest goes away.
I could put it back.
There was a problem hiding this comment.
Just trying to reduce or at least be aware of all subjects that potentially need to be allowed/denied when it comes to permissions or import/export rules.
There was a problem hiding this comment.
Running a sub leak test now that R.I. showed me, so trying to reproduce that now.
server/stream.go
Outdated
| @@ -1556,14 +1593,20 @@ func (mset *stream) setSourceConsumer(sname string, seq uint64) { | |||
| if ext != nil { | |||
| deliverSubject = strings.ReplaceAll(ext.DeliverPrefix+syncSubject(".S"), "..", ".") | |||
| } else { | |||
| deliverSubject = syncSubject("$JS.S") | |||
| deliverSubject = syncSubject("$JSDC.S") | |||
… flow control subjects for consumers. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core