Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JS when a leafnode cluster extends and shares a system account. #2108

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

derekcollison
Copy link
Member

This PR improves the setup that has a remote leafnode cluster extending a cluster or supercluster and the JetStream domain. We want to ensure the remote cluster places correctly and does not try to elect its own leader.

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

…and they share the system account make the leafnode servers observers.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@matthiashanel matthiashanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 6788c75 into master Apr 13, 2021
@derekcollison derekcollison deleted the lnjs branch April 13, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants