[Fixed] leaf node subscription permission negotiation. #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On connect all subscription where sent by the soliciting leaf node. If creds contains sub deny permissions, the leaf node would be disconnected. This waits for the permissions to be exchanged and checks permissions before sending subscriptions. Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
force-pushed
the
permissions
branch
from
bfae633 to
5169038
Compare
kozlovic
requested changes
Apr 9, 2021
incorporate review comments Signed-off-by: Matthias Hanel <mh@synadia.com>
kozlovic
requested changes
Apr 9, 2021
Signed-off-by: Matthias Hanel <mh@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On connect all subscription where sent by the soliciting leaf node.
If creds contains sub deny permissions, the leaf node would be
disconnected.
This waits for the permissions to be exchanged and checks permissions
before sending subscriptions.
Signed-off-by: Matthias Hanel mh@synadia.com
split up leafNodeFinishConnectProcess into two functions.
When expecting multiple messages in a row, use a buffer to store everything after the left most match.
This can be used a lot more. But there are unrelated tests that rely on the old behavior. (will address separately)