Report an error if we fail to load an account on a stream assignment. #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Apr 7, 2021
server/jetstream_cluster_test.go
Outdated
|
|
||
| _, err := js.AddStream(&nats.StreamConfig{Name: "F", Replicas: 3}) | ||
| if err == nil || !strings.Contains(err.Error(), "account not found") { | ||
| t.Fatalf("Expected an 'account not found' error but got none") |
There was a problem hiding this comment.
Would change to .. but got %v, since it could be nil or an unexpected error.
…end error back to metaleader. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
account_load
branch
from
8689a76 to
1ea4a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expected an account load to not fail but this is possible with resolvers.
If we can not load the account report back to the metaleader the error.
Consumers overlay the same peer group and need to exist prior, so I believe we only need to check on creating a stream, not on update or creating a consumer.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core