[FIXED] Websocket: TLS configuration not updated on reload #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although we do not support websocket configuration changes, we usually try to support changes to TLS certificates, etc.. The way websocket is handled (using an http server), the TLS config was given on startup and updates following a configuration reload would not be reflected. Using a tls.Config function that allows passing the tls config prior to handshake seem to workaround this issue. I have added a test that demonstrate that the TLS configuration is really updated after the reload. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
websocket_tls_reload
branch
from
95dc350 to
f96f36c
Compare
|
I have rebased from master to use @variadico new helper to remove config file in the new test (since helper checks/report errors). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we do not support websocket configuration changes, we usually
try to support changes to TLS certificates, etc..
The way websocket is handled (using an http server), the TLS config
was given on startup and updates following a configuration reload
would not be reflected.
Using a tls.Config function that allows passing the tls config
prior to handshake seem to workaround this issue.
I have added a test that demonstrate that the TLS configuration
is really updated after the reload.
Signed-off-by: Ivan Kozlovic ivan@synadia.com