Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put typestring to map and add tests #2064

Merged
merged 1 commit into from
Apr 5, 2021
Merged

put typestring to map and add tests #2064

merged 1 commit into from
Apr 5, 2021

Conversation

alexpantyukhin
Copy link
Contributor

@alexpantyukhin alexpantyukhin commented Apr 5, 2021 •
edited
Loading

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves #

Changes proposed in this pull request:

  • substitute switch-case with map in the typeString function.

/cc @nats-io/core

derekcollison
derekcollison approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks.

@derekcollison derekcollison requested a review from kozlovic April 5, 2021 14:59
kozlovic
kozlovic requested changes Apr 5, 2021
View reviewed changes
@alexpantyukhin
Copy link
Contributor Author

@kozlovic Thank you very much for your feedback! I have fixed your review notes. Please re-review.

kozlovic
kozlovic approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@kozlovic kozlovic merged commit c0df835 into nats-io:master Apr 5, 2021
@alexpantyukhin alexpantyukhin deleted the typestrings_to_map branch April 5, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexpantyukhin @derekcollison @kozlovic