Skip to content

Commit

Permalink
Fix data race in TestNRGTermDoesntRollBackToPtermOnCatchup (#5991)
Browse files Browse the repository at this point in the history
Signed-off-by: Neil Twigg <neil@nats.io>
  • Loading branch information
derekcollison authored Oct 11, 2024
2 parents 378bad6 + 3586b05 commit c94b5f9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion server/raft_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,8 @@ func TestNRGTermDoesntRollBackToPtermOnCatchup(t *testing.T) {
require_Equal(t, rn.pindex, 6)
}
}
// This will make followers run a catchup.
ae := newAppendEntry(leader.id, leader.term, leader.commit, leader.pterm, leader.pindex, nil)
rg.unlockAll()

arInbox := nc.NewRespInbox()
Expand All @@ -800,7 +802,6 @@ func TestNRGTermDoesntRollBackToPtermOnCatchup(t *testing.T) {
// In order to trip this condition, we need to send an append entry that
// will trick the followers into running a catchup. In the process they
// were setting the term back to pterm which is incorrect.
ae := newAppendEntry(leader.id, leader.term, leader.commit, leader.pterm, leader.pindex, nil)
b, err := ae.encode(nil)
require_NoError(t, err)
require_NoError(t, nc.PublishMsg(&nats.Msg{
Expand Down

0 comments on commit c94b5f9

Please sign in to comment.