Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-canvas): iOS bitmaps are flipped during initialization #61

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

CatchABus
Copy link
Contributor

It seems that iOS blank bitmaps need flipping during initialization.

@CatchABus
Copy link
Contributor Author

@farfromrefug Does _createContextFromImage really need the save/restore part? As a user, I imagine myself drawing few things on top of given image or even scale it. See https://github.com/nativescript-community/ui-canvas/blob/master/src/ui-canvas/canvas.ios.ts#L1852

@farfromrefug
Copy link
Member

@CatchABus i see what you mean yes we can remove save / restore part so that you can draw on the image with the correct scale.

@CatchABus
Copy link
Contributor Author

@CatchABus i see what you mean yes we can remove save / restore part so that you can draw on the image with the correct scale.

Done! Thanks for confirmation 😃

@farfromrefug farfromrefug merged commit f5d4319 into master Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants