v2 release

[rynop]

Starting a list here of things that need to be included in the v2 release before the v2 branch can be merged into master. The v2 branch is primed from the https://github.com/Akylas/nativescript-bluetooth fork. See https://github.com/Akylas/nativescript-bluetooth/issues/5 for history.

My hope is we can discuss at a high level what needs to be in v2, then make an issue for each feature adding it to the 2.0.0 milestone. In the individual feature issues we can have lower level discussion if needed.

• Migration/upgrade guide
• Comb through README.md to make sure features/changes in v2 branch are documented.
• demo-ng ts overhaul (was written long ago before features like async/await)
• Update demo with features/changes that are included in 2.0.0

@EddyVerbruggen, @farfromrefug, and others, feel free to make suggestions below and/or tag existing issues with v2 and add em to the 2.0.0 milestone.

[farfromrefug]

2.0.0-beta.1 released. Already using it in prod

Hi @farfromrefug, could you provide a brief breakdown on how to manually import this branch of the plug-in into an existing project?

I already tried copying the downloaded nativescript-bluetooth-2 folder into node_modules and using it via var bluetooth = require("nativescript-bluetooth-2"); but I get an error saying:

Cannot find module 'nativescript-bluetooth-2'

I'm mainly interested in using the filters functionality of startScanning, since that feature seems to be broken in the master branch.

EDIT: Scratch that last part, I wasn't advertising the serviceUUIDs of my peripheral correctly.

[farfromrefug]

@Phil-Sch no need use special branch. Simply use the beta tag!
Look here i am at 2.0.0-beta.11

@farfromrefug thank you very much! Indeed, npm install nativescript-bluetooth@beta did the trick.

[farfromrefug]

@EddyVerbruggen What do you think about making v2 official?
I really think beta 14 is a really good candidate.

[EddyVerbruggen]

@farfromrefug Happy to do so! Anyone here who doesn't think that's a good idea?

I've been using the latest beta versions for some time now and they work like a charm. 💙

[farfromrefug]

@EddyVerbruggen BTW we would need some in getting the documention updated. Honestly not really interested by docs :s Anyore interested?

[erikbjork]

I have found two bugs in 2.0.0-beta.12 which I think still exists in the latest beta (2.0.0-beta.14). They're both in the Android implementation. One is a failure when a scanned device has no device name and the other is a problem with this.connection map containing null values. I have patches for the 2.0.0-beta.12 release.

I will confirm that they still exists in the latest beta and, if so, get back with better descriptions of the bugs. Do you want me to post them as separate issues?

[farfromrefug]

@erikbjork let s handle them here. a walkthrough on how to reproduce them would be awesome. maybe even a nodejs bleno example to simulate a device if it depends on it. need to check but think I created one in the v2 branch

[erikbjork]

I could not run my application with the 2.0.0-beta.14 release (because of es2015 import issues). But @farfromrefug has got the details and will make some changes.

[farfromrefug]

@erikbjork issue is fixed right now. Anyone to help a bit on the doc?

[farfromrefug]

@EddyVerbruggen I am starting to think i should create a new plugin based on v2. The reason is the issue people have with understanding that that plugin is for BLE devices.
So i was thinking about creating nativescript-ble out of the v2 branch.
And in the future maybe this plugin could become the plugin for Bluetooth 2.0. Dont want to create the new plugin without brainstorming with you