Skip to content

Conversation

Copy link

Copilot AI commented Jan 28, 2026

Unit tests for Muon optimizer fail after PR deepspeedai#7808 added assertion that Muon is incompatible with reduce_scatter=True. Tests were using the default reduce_scatter=True value.

Changes

tests/unit/ops/muon/test_muon.py

  • Set reduce_scatter=False for Muon optimizer tests, keep True for Adam tests
  • Add TestMuonReduceScatterIncompatibility to verify assertion triggers correctly
config_dict = {
    "zero_optimization": {
        "stage": zero_stage,
        "reduce_scatter": False if optimizer_type == "muon" else True,
    }
}

The new test verifies that initializing Muon with reduce_scatter=True raises AssertionError with message "incompatible with Muon optimizer".

Original prompt

The newly created branch "fix_unit_tests" in repository "nathon-lee/DeepSpeed_woo" is based on the branch fix_issue_7807. It aims to address the unit test failures observed in pull request "deepspeedai#7808". The specific failure logs and error messages are associated with this PR (available at: deepspeedai#7808) and may provide detailed context about the issues at hand.

Objective:

Let me know if additional information is needed before starting.

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 28, 2026 05:54
Co-authored-by: nathon-lee <248585198+nathon-lee@users.noreply.github.com>
Co-authored-by: nathon-lee <248585198+nathon-lee@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix unit test failures from pull request 7808 Fix Muon unit tests for reduce_scatter incompatibility assertion Jan 28, 2026
Copilot AI requested a review from nathon-lee January 28, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants