Fix jquery deprecation. #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for your PR and your investigative work (checking all the old PR's). I had to re-check the #447, I am very glad you did this work. For me it was not a big issue, because I always use turbolinks, but I understand the current code does not work if people are only using jquery and not turbolinks (any version thereof). |
|
Am I right in thinking this hasn't been published in the NPM package yet? |
|
Does this change warrant a bump in the version number? Does it change anything for users that don't use turbolinks? e.g. is it backwards compatible? I know it's a quite a while since it was merged, but just wondering as I've been upgrading to JQuery 3 and have had to fix Cocoon to this commit hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated pull request to fix the jquery ready event deprecation. As more and more deployments are moving to newer Jquery versions, it would be a good idea to fix this once and for all.
I've reviewed all the previous pull requests such as #575, #447, and #379. It looks like all of them had problems but #447 had a proper fix in the notes, only the original contributor never updated the pull request.
I've updated the pull based on the solution in #447 but with the updated events
page:load turbolinks:load turbo:load.