Skip to content
This repository has been archived by the owner on Nov 21, 2022. It is now read-only.

Commit

Permalink
Merge branch 'remove-label-cpu-from-dsa-dt-bindings'
Browse files Browse the repository at this point in the history
Vladimir Oltean says:

====================
Remove label = "cpu" from DSA dt-bindings

As explained in more detail in patch 1/3, label = "cpu" is not part of
DSA's device tree bindings, yet we have some checks in the dt-schema for
mt7530 which are written as if it was.

Reformulate those checks, and remove all occurrences of this seemingly
used, but actually unused, property from the binding examples.
====================

Link: https://lore.kernel.org/r/20220912175058.280386-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
kuba-moo committed Sep 20, 2022
2 parents f0bd32c + 9cc115d commit 2dc81a0
Show file tree
Hide file tree
Showing 12 changed files with 3 additions and 37 deletions.
1 change: 0 additions & 1 deletion Documentation/devicetree/bindings/net/dsa/ar9331.txt
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ eth1: ethernet@1a000000 {

switch_port0: port@0 {
reg = <0x0>;
label = "cpu";
ethernet = <&eth1>;

phy-mode = "gmii";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ examples:
};
ethernet-port@3 {
reg = <3>;
label = "cpu";
ethernet = <&fec1>;
phy-mode = "rgmii-id";
Expand Down
2 changes: 0 additions & 2 deletions Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ examples:
port@8 {
reg = <8>;
label = "cpu";
phy-mode = "rgmii-txid";
ethernet = <&eth0>;
fixed-link {
Expand Down Expand Up @@ -252,7 +251,6 @@ examples:
port@8 {
ethernet = <&amac2>;
label = "cpu";
reg = <8>;
phy-mode = "internal";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ examples:
port@0 {
reg = <0>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "mii";
Expand Down
2 changes: 0 additions & 2 deletions Documentation/devicetree/bindings/net/dsa/lan9303.txt
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ I2C managed mode:

port@0 { /* RMII fixed link to master */
reg = <0>;
label = "cpu";
ethernet = <&master>;
};

Expand Down Expand Up @@ -83,7 +82,6 @@ MDIO managed mode:

port@0 {
reg = <0>;
label = "cpu";
ethernet = <&master>;
};

Expand Down
1 change: 0 additions & 1 deletion Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ switch@e108000 {

port@6 {
reg = <0x6>;
label = "cpu";
ethernet = <&eth0>;
};
};
Expand Down
22 changes: 3 additions & 19 deletions Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,8 @@ patternProperties:
allOf:
- $ref: dsa-port.yaml#
- if:
properties:
label:
const: cpu
required: [ ethernet ]
then:
required:
- phy-mode

properties:
reg:
enum:
Expand All @@ -187,9 +182,7 @@ $defs:
patternProperties:
"^(ethernet-)?port@[0-9]+$":
if:
properties:
label:
const: cpu
required: [ ethernet ]
then:
if:
properties:
Expand All @@ -215,9 +208,7 @@ $defs:
patternProperties:
"^(ethernet-)?port@[0-9]+$":
if:
properties:
label:
const: cpu
required: [ ethernet ]
then:
if:
properties:
Expand Down Expand Up @@ -334,7 +325,6 @@ examples:
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "rgmii";
Expand Down Expand Up @@ -398,7 +388,6 @@ examples:
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "trgmii";
Expand Down Expand Up @@ -463,7 +452,6 @@ examples:
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "2500base-x";
Expand Down Expand Up @@ -530,7 +518,6 @@ examples:
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "trgmii";
Expand Down Expand Up @@ -619,7 +606,6 @@ examples:
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "trgmii";
Expand Down Expand Up @@ -708,7 +694,6 @@ examples:
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "trgmii";
Expand Down Expand Up @@ -796,7 +781,6 @@ examples:
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "trgmii";
Expand Down
2 changes: 0 additions & 2 deletions Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ examples:
};
port@5 {
reg = <5>;
label = "cpu";
ethernet = <&eth0>;
phy-mode = "rgmii";
Expand Down Expand Up @@ -146,7 +145,6 @@ examples:
};
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&eth0>;
phy-mode = "rgmii";
Expand Down
3 changes: 0 additions & 3 deletions Documentation/devicetree/bindings/net/dsa/qca8k.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ examples:
port@0 {
reg = <0>;
label = "cpu";
ethernet = <&gmac1>;
phy-mode = "rgmii";
Expand Down Expand Up @@ -221,7 +220,6 @@ examples:
port@0 {
reg = <0>;
label = "cpu";
ethernet = <&gmac1>;
phy-mode = "rgmii";
Expand Down Expand Up @@ -268,7 +266,6 @@ examples:
port@6 {
reg = <0>;
label = "cpu";
ethernet = <&gmac1>;
phy-mode = "sgmii";
Expand Down
2 changes: 0 additions & 2 deletions Documentation/devicetree/bindings/net/dsa/realtek.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ examples:
};
port@5 {
reg = <5>;
label = "cpu";
ethernet = <&gmac0>;
phy-mode = "rgmii";
fixed-link {
Expand Down Expand Up @@ -277,7 +276,6 @@ examples:
};
port@6 {
reg = <6>;
label = "cpu";
ethernet = <&fec1>;
phy-mode = "rgmii";
tx-internal-delay-ps = <2000>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ examples:
port@4 {
reg = <4>;
ethernet = <&gmac2>;
label = "cpu";
phy-mode = "internal";
fixed-link {
Expand Down
2 changes: 0 additions & 2 deletions Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ switch@0 {
};
vsc: port@6 {
reg = <6>;
label = "cpu";
ethernet = <&gmac1>;
phy-mode = "rgmii";
fixed-link {
Expand Down Expand Up @@ -117,7 +116,6 @@ switch@2,0 {
};
vsc: port@6 {
reg = <6>;
label = "cpu";
ethernet = <&enet0>;
phy-mode = "rgmii";
fixed-link {
Expand Down

0 comments on commit 2dc81a0

Please sign in to comment.