Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Icon): switch to non-deprecated href attribute #243

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented Oct 22, 2024

Fixes #208

@stramel stramel added the bug Something isn't working label Oct 22, 2024
@stramel stramel self-assigned this Oct 22, 2024
Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: e757666

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:40am
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:40am

Copy link
Owner

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The deprecated xlink:href attribute should be replaced with href
2 participants