Float to_i
should raise a FloatDomainError
when NaN
#646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Float
to_i
should raise aFloatDomainError
whenNaN
There is no test for this in the
to_i
example in spec/core . I added one and will then try upstream it toruby/spec
I notice that the change recommended for the stack allocated Float has been fixed by a similar commit so did not include it
It was:
vs what is now in master