Amazon Seller Partner: make fields optional (airbytehq#23300)

* update amazon sp config * update doc * fix spec test * uncomment accept test * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
natalia-miinto · Feb 22, 2023 · 5e73eec · 5e73eec
1 parent aa08378
commit 5e73eec
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 9 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -69,7 +69,7 @@
 - name: Amazon Seller Partner
   sourceDefinitionId: e55879a8-0ef8-4557-abcf-ab34c53ec460
   dockerRepository: airbyte/source-amazon-seller-partner
-  dockerImageTag: 0.2.31
+  dockerImageTag: 0.2.32
   sourceType: api
   documentationUrl: https://docs.airbyte.com/integrations/sources/amazon-seller-partner
   icon: amazonsellerpartner.svg

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -932,7 +932,7 @@
               type: "string"
               path_in_connector_config:
               - "client_secret"
-- dockerImage: "airbyte/source-amazon-seller-partner:0.2.31"
+- dockerImage: "airbyte/source-amazon-seller-partner:0.2.32"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/amazon-seller-partner"
     changelogUrl: "https://docs.airbyte.com/integrations/sources/amazon-seller-partner"
@@ -1080,9 +1080,6 @@
       - "lwa_app_id"
       - "lwa_client_secret"
       - "refresh_token"
-      - "aws_access_key"
-      - "aws_secret_key"
-      - "role_arn"
       - "replication_start_date"
       - "aws_environment"
       - "region"

diff --git a/airbyte-integrations/connectors/source-amazon-seller-partner/Dockerfile b/airbyte-integrations/connectors/source-amazon-seller-partner/Dockerfile
@@ -13,5 +13,5 @@ ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
 
-LABEL io.airbyte.version=0.2.31
+LABEL io.airbyte.version=0.2.32
 LABEL io.airbyte.name=airbyte/source-amazon-seller-partner
diff --git a/airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/spec.json b/airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/spec.json
@@ -141,9 +141,6 @@
       "lwa_app_id",
       "lwa_client_secret",
       "refresh_token",
-      "aws_access_key",
-      "aws_secret_key",
-      "role_arn",
       "replication_start_date",
       "aws_environment",
       "region"

diff --git a/...integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.py b/...integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.py
@@ -47,20 +47,23 @@ class Config:
     )
 
     aws_access_key: str = Field(
+        None,
         description="Specifies the AWS access key used as part of the credentials to authenticate the user.",
         title="AWS Access Key",
         airbyte_secret=True,
         order=5,
     )
 
     aws_secret_key: str = Field(
+        None,
         description="Specifies the AWS secret key used as part of the credentials to authenticate the user.",
         title="AWS Secret Access Key",
         airbyte_secret=True,
         order=6,
     )
 
     role_arn: str = Field(
+        None,
         description="Specifies the Amazon Resource Name (ARN) of an IAM role that you want to use to perform operations requested using this profile. (Needs permission to 'Assume Role' STS).",
         title="Role ARN",
         airbyte_secret=True,

diff --git a/docs/integrations/sources/amazon-seller-partner.md b/docs/integrations/sources/amazon-seller-partner.md
@@ -129,6 +129,7 @@ So, for any value that exceeds the limit, the `period_in_days` will be automatic
 
 | Version  | Date       | Pull Request                                               | Subject                                                                |
 |:---------|:-----------|:-----------------------------------------------------------|:-----------------------------------------------------------------------|
+| `0.2.32` | 2022-02-21 | [\#23300](https://github.com/airbytehq/airbyte/pull/23300) | Make AWS Access Key, AWS Secret Access and Role ARN optional  |
 | `0.2.31` | 2022-01-10 | [\#16430](https://github.com/airbytehq/airbyte/pull/16430) | Implement slicing for report streams                                   |
 | `0.2.30` | 2022-12-28 | [\#20896](https://github.com/airbytehq/airbyte/pull/20896) | Validate connections without orders data                               | 
 | `0.2.29` | 2022-11-18 | [\#19581](https://github.com/airbytehq/airbyte/pull/19581) | Use user provided end date for GET_SALES_AND_TRAFFIC_REPORT            |                           |