Skip to content

Commit

Permalink
Generate 500.html with assets:precompile, remove loading from Google …
Browse files Browse the repository at this point in the history
…Fonts (mastodon#5067)
  • Loading branch information
Gargron authored Sep 25, 2017
1 parent b982d54 commit 2c8e3fb
Show file tree
Hide file tree
Showing 8 changed files with 40 additions and 68 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public/system
public/assets
public/packs
public/packs-test
public/500.html
.env
.env.production
node_modules/
Expand Down
21 changes: 21 additions & 0 deletions app/javascript/styles/basics.scss
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,27 @@ body {
height: 100%;
padding: 0;
}

&.error {
text-align: center;
color: $ui-primary-color;
padding: 20px;

.dialog img {
display: block;
margin: 20px auto;
margin-top: 50px;
max-width: 600px;
width: 100%;
height: auto;
}

.dialog h1 {
font-size: 20px;
line-height: 28px;
font-weight: 400;
}
}
}

button {
Expand Down
5 changes: 5 additions & 0 deletions app/views/errors/500.html.haml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- content_for :page_title do
= t('errors.500')

- content_for :content do
= t('errors.500')
28 changes: 3 additions & 25 deletions app/views/layouts/error.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,9 @@
%meta{ charset: 'utf-8' }/
%title= yield :page_title
%meta{ content: 'width=device-width,initial-scale=1', name: 'viewport' }/
%link{ href: 'https://fonts.googleapis.com/css?family=Roboto:400', rel: 'stylesheet' }/
:css
body {
font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, sans-serif;
background: #282c37;
color: #9baec8;
text-align: center;
margin: 0;
padding: 20px;
}

.dialog img {
display: block;
margin: 20px auto;
margin-top: 50px;
max-width: 600px;
width: 100%;
height: auto;
}

.dialog h1 {
font: 20px/28px -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, sans-serif;
font-weight: 400;
}
%body
= stylesheet_pack_tag 'common', media: 'all'
= stylesheet_pack_tag Setting.default_settings['theme'], media: 'all'
%body.error
.dialog
%img{ alt: 'Mastodon', src: '/oops.png' }/
%div
Expand Down
1 change: 1 addition & 0 deletions config/i18n-tasks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ ignore_missing:
- 'sessions.{browsers,platforms}.*'
- 'terms.body_html'
- 'application_mailer.salutation'
- 'errors.500'
ignore_unused:
- 'activemodel.errors.*'
- 'activerecord.attributes.*'
Expand Down
1 change: 1 addition & 0 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ en:
content: Security verification failed. Are you blocking cookies?
title: Security verification failed
'429': Throttled
'500': We're sorry, but something went wrong.
noscript_html: To use the Mastodon web application, please enable JavaScript. Alternatively, try one of the <a href="https://github.com/tootsuite/documentation/blob/master/Using-Mastodon/Apps.md">native apps</a> for Mastodon for your platform.
exports:
blocks: You block
Expand Down
8 changes: 8 additions & 0 deletions lib/tasks/assets.rake
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# frozen_string_literal: true

if Rake::Task.task_defined?('assets:precompile')
Rake::Task['assets:precompile'].enhance do
html = ApplicationController.render('errors/500', layout: 'error')
File.write(Rails.root.join('public', '500.html'), html)
end
end
43 changes: 0 additions & 43 deletions public/500.html

This file was deleted.

0 comments on commit 2c8e3fb

Please sign in to comment.