[759]Create webhook #822
[759]Create webhook #822
Conversation
thinhpham-nashtech
force-pushed
the
#759-create_webhook
branch
from
1272e4a
to
c6df056
Compare
There was a problem hiding this comment.
Can you refer to the implementation of other services that are using ApiClientService.ts ?
webhook/pom.xml
Outdated
| <groupId>org.mapstruct</groupId> | ||
| <artifactId>mapstruct</artifactId> | ||
| <version>1.6.0.Beta1</version> | ||
| </dependency> |
There was a problem hiding this comment.
We already defined mapstruct in parent pom.xml with version 1.4.1.Final. Why do you need another version here?
| public static final String EVENT_URL = "/backoffice/events"; | ||
|
|
||
| public static final String CODE_200 = "200"; | ||
| public static final String OK = "Ok"; |
There was a problem hiding this comment.
You can use org.springframework.http.HttpStatus instead of defining these constants
There was a problem hiding this comment.
Because the ApiConstant.CODE_200 is using in the value of annotation. And they don't accept the enum value like HttpStatus.OK.value()
| paths: | ||
| - "webhook/**" | ||
| - ".github/workflows/actions/action.yaml" | ||
| - ".github/workflows/webhook-ci.yaml" |
.github/workflows/webhook-ci.yaml
Outdated
| - "webhook/**" | ||
| - ".github/workflows/actions/action.yaml" | ||
| - ".github/workflows/webhook-ci.yaml" | ||
|
|
| ErrorVm errorVm = new ErrorVm(HttpStatus.BAD_REQUEST.toString(), | ||
| HttpStatus.BAD_REQUEST.getReasonPhrase(), e.getMessage()); | ||
| return ResponseEntity.badRequest().body(errorVm); | ||
| } |
There was a problem hiding this comment.
Add handling 500 as https://github.com/nashtech-garage/yas/pull/808/files
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
No description provided.