Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#803 Add maven checkstyle plugin to pom.xml #814

Closed
wants to merge 3 commits into from
Closed

#803 Add maven checkstyle plugin to pom.xml #814

wants to merge 3 commits into from

Conversation

nashtech-hieunguyenchi5
Copy link
Contributor

No description provided.

@nashtech-hieunguyenchi5 nashtech-hieunguyenchi5 force-pushed the #803-add-maven-checkstyle-plugin branch 3 times, most recently from b2fb3c1 to 6035d6d Compare August 1, 2024 02:06
thiennn
thiennn reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@thiennn thiennn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should move the file checkstyle.xml to the root folder

@thiennn
Copy link
Contributor

thiennn commented Aug 1, 2024

Show the checkstyle report on in GitHub Actions, like https://github.com/jwgmeligmeyling/checkstyle-github-action

@nashtech-hieunguyenchi5 nashtech-hieunguyenchi5 force-pushed the #803-add-maven-checkstyle-plugin branch 3 times, most recently from cd96a5a to 994e41e Compare August 5, 2024 02:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'customer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'media'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'payment'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'payment-paypal'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'backoffice-bff'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'storefront-bff'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'tax'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'product'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'promotion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'search'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'rating'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'location'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'order'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'yas'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'inventory'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiennn thiennn thiennn left review comments

@khanhtrand khanhtrand Awaiting requested review from khanhtrand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nashtech-hieunguyenchi5 @thiennn