Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment service #671

Merged
merged 8 commits into from
May 2, 2023
Merged

Payment service #671

merged 8 commits into from
May 2, 2023

Conversation

LEHOANGGLAM
Copy link
Contributor

@LEHOANGGLAM LEHOANGGLAM commented Apr 25, 2023 •
edited
Loading

Hi Mr. @thiennn , Please create project-key in SonarCloud so that sonar can scan " payment service", thanks
Create Payment service with port: 8081

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

[order] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

[storefront-bff] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

khoahd7621
khoahd7621 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@khoahd7621 khoahd7621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

[yas-payment] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@LEHOANGGLAM LEHOANGGLAM merged commit 400822b into main May 2, 2023
@LEHOANGGLAM LEHOANGGLAM deleted the payment-service branch May 2, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenvanhadncntt nguyenvanhadncntt nguyenvanhadncntt approved these changes

@khoahd7621 khoahd7621 khoahd7621 approved these changes

@DieuNguyenThi DieuNguyenThi DieuNguyenThi approved these changes

@thiennn thiennn Awaiting requested review from thiennn

@lnghia lnghia Awaiting requested review from lnghia

@kiettrangthuan kiettrangthuan Awaiting requested review from kiettrangthuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LEHOANGGLAM @nguyenvanhadncntt @khoahd7621 @DieuNguyenThi