Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#460 - implement address book for user profile #577

Merged
merged 1 commit into from
Apr 3, 2023
Merged

#460 - implement address book for user profile #577

merged 1 commit into from
Apr 3, 2023

Conversation

kiettrangthuan
Copy link
Contributor

No description provided.

@kiettrangthuan kiettrangthuan force-pushed the 460_add_manage_address_book_for_user_profile branch from da01b27 to 8751fad Compare April 3, 2023 04:34
@kiettrangthuan kiettrangthuan force-pushed the 460_add_manage_address_book_for_user_profile branch from d1c2117 to 2d020a3 Compare April 3, 2023 06:26
LEHOANGGLAM
LEHOANGGLAM requested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@LEHOANGGLAM LEHOANGGLAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, need some additional

customer/src/main/java/com/yas/customer/model/UserAddress.java Outdated
@UpdateTimestamp
private ZonedDateTime lastModifiedOn;

@LastModifiedBy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CreationTimestamp ,@createdby, @UpdateTimestamp, @LastModifiedBy. These annotation, they will no longer have any effect since there is no listener to handle these annotations. Add annotation @EntityListeners(CustomAuditingEntityListener.class)
Reference
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank Lam

@kiettrangthuan kiettrangthuan force-pushed the 460_add_manage_address_book_for_user_profile branch from 2d020a3 to 0e50801 Compare April 3, 2023 07:41
LEHOANGGLAM
LEHOANGGLAM previously requested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@LEHOANGGLAM LEHOANGGLAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need few changes

@LEHOANGGLAM LEHOANGGLAM self-requested a review April 3, 2023 08:39
LEHOANGGLAM
LEHOANGGLAM approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@LEHOANGGLAM LEHOANGGLAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should separate PR into smaller pieces for us to easily review. Sample 1 PR backend, 1 PR frontend

@kiettrangthuan kiettrangthuan force-pushed the 460_add_manage_address_book_for_user_profile branch from 0e50801 to 31870d1 Compare April 3, 2023 10:45
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

[customer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

[storefront-bff] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

[location] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

[storefront] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kiettrangthuan kiettrangthuan merged commit 3e700e1 into main Apr 3, 2023
@kiettrangthuan kiettrangthuan deleted the 460_add_manage_address_book_for_user_profile branch April 3, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LEHOANGGLAM LEHOANGGLAM LEHOANGGLAM approved these changes

@chanhnguyen6975 chanhnguyen6975 chanhnguyen6975 approved these changes

@DieuNguyenThi DieuNguyenThi Awaiting requested review from DieuNguyenThi

@thiennn thiennn Awaiting requested review from thiennn

@khanhtrand khanhtrand Awaiting requested review from khanhtrand

@nguyenvanhadncntt nguyenvanhadncntt Awaiting requested review from nguyenvanhadncntt

@lnghia lnghia Awaiting requested review from lnghia

@khoahd7621 khoahd7621 Awaiting requested review from khoahd7621

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiettrangthuan @LEHOANGGLAM @chanhnguyen6975