New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1174: Apply promotion code when checkout #1247

Merged

LoanNguyenT5 merged 10 commits into main from apply-promotion-to-checkout

Nov 1, 2024

Contributor

LoanNguyenT5 commented Oct 30, 2024

Apply promotion code when checkout at screen Oreder and Checkout
Update usage_count after code apply success
Insert promotion code into table promotion_usage
Update script DDL for table promotion_usage ( Set default for create_on and create_by)


          #1174: Apply promotion code when checkout, update table count usage a…

91fa4e3

…fter apply code

github-actions bot commented Oct 30, 2024 •

edited

Loading

Promotion Coverage Report

Overall Project	78.58% `-5.27%`	❌
Files changed	49.72%	❌

File	Coverage
PromotionController.java	89.06% `-10.94%`	❌
PromotionService.java	87.93% `-10.66%`	❌
PromotionUsageVm.java	0%	❌

loannguyent5 and others added 4 commits

October 30, 2024 13:37


          #1174: Fix build

c8c06d7


          Merge branch 'main' into apply-promotion-to-checkout

a5e7436


          #1174: Fix build

b8caa56


          #1174: Fix IT test

1549ac7

github-actions bot commented Oct 31, 2024 •

edited

Loading

Order Coverage Report

Overall Project	78.28% `-0.42%`	❌
Files changed	88.89%	🍏

File	Coverage
PromotionUsageVm.java	100%	🍏
CheckoutPostVm.java	100%	🍏
CheckoutVm.java	100%	🍏
CheckoutMapper.java	100%	🍏
PromotionService.java	88.89% `-11.11%`	🍏
OrderService.java	79.25% `-0.17%`	🍏
OrderItemGetVm.java	0% `-11.11%`	❌

nguyenvanhadncntt approved these changes

View reviewed changes

loannguyent5 added 2 commits

October 31, 2024 15:15


          #1174: Fix Checkstyle

9d1f95b


          #1174: Fix Checkstyle 2

b4ee00d

VanCongBang approved these changes

View reviewed changes

loannguyent5 added 3 commits

November 1, 2024 10:48


          #1174: Fix Checkstyle 3

a6c613b


          #1174: Merge main

304240d


          #1174: Fix checkstyle

9dba8e5

sonarcloud bot commented Nov 1, 2024

Quality Gate passed for 'storefront'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Nov 1, 2024

Quality Gate passed for 'order'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Nov 1, 2024

Quality Gate passed for 'promotion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
10.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

LoanNguyenT5 merged commit c8b3afc into main

12 checks passed

LoanNguyenT5 deleted the apply-promotion-to-checkout branch

November 1, 2024 04:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet