Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1003 payment provider #1243

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Feature/1003 payment provider #1243

merged 9 commits into from
Oct 31, 2024

Conversation

khanhtrand
Copy link
Contributor

No description provided.

@khanhtranduy
[Payment] Embedded Payment-Paypal project into Payment project like a…
8df2beb 
… dependency #1003
@khanhtranduy
Merge branch 'main' of https://github.com/nashtech-garage/yas into fe…
fd8d658 
…ature/1003-payment-provider

# Conflicts:
#	payment-paypal/src/main/java/com/yas/payment/paypal/service/OrderService.java
#	payment-paypal/src/main/java/com/yas/payment/paypal/service/PaypalService.java
#	payment-paypal/src/main/java/com/yas/payment/paypal/viewmodel/OrderVm.java
#	payment-paypal/src/main/java/com/yas/paymentpaypal/config/ServiceUrlConfig.java
#	payment-paypal/src/main/java/com/yas/paymentpaypal/service/PaymentService.java
#	payment-paypal/src/main/resources/application.properties
#	payment-paypal/src/test/java/com/yas/payment/paypal/service/OrderServiceTest.java
#	payment-paypal/src/test/java/com/yas/payment/paypal/service/PaypalServiceTest.java
#	payment-paypal/src/test/java/com/yas/paymentpaypal/service/PaymentServiceTest.java
#	payment/src/main/java/com/yas/payment/service/OrderService.java
@khanhtranduy
[Payment] Embedded Payment-Paypal project into Payment project like a…
907d016 
… dependency #1003
@khanhtranduy
[Payment] Embedded Payment-Paypal project into Payment project like a…
6872f4b 
… dependency #1003
@github-actions GitHub Actions
Copy link

Storefront BFF Coverage Report

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Recommendation Coverage Report

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Media Coverage Report

Overall Project 87.19% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Inventory Coverage Report

Overall Project 90.52% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Customer Coverage Report

Overall Project 89.24% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Webhook Coverage Report

Overall Project 77.63% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Rating Coverage Report

Overall Project 81.94% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Promotion Coverage Report

Overall Project 82.95% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Order Coverage Report

Overall Project 77.46% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Location Coverage Report

Overall Project 93.48% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Cart Coverage Report

Overall Project 90.44% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Tax Coverage Report

Overall Project 88.12% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Product Coverage Report

Overall Project 78.11% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Search Coverage Report

Overall Project 93.47% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Payment Paypal Coverage Report

Overall Project 80.34% -11.27% 🍏
Files changed 76.96% 🍏

File Coverage
CheckoutIdHelper.java 100% 🍏
PaypalCapturePaymentRequest.java 100% 🍏
PaypalCreatePaymentRequest.java 100% 🍏
PaypalCreatePaymentResponse.java 100% 🍏
PaypalCapturePaymentResponse.java 100% 🍏
PaypalService.java 100% 🍏
MessagesUtils.java 100% 🍏
AuthenticationUtils.java 100% 🍏
AbstractCircuitBreakFallbackHandler.java 0% 🍏
PayPalHttpClientInitializer.java 0% ❌
Constants.java 0% 🍏

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Payment Coverage Report

Overall Project 69.02% -15.27% ❌
Files changed 69.14% 🍏

File Coverage
PaymentProviderController.java 100% 🍏
CapturePaymentRequestVm.java 100% 🍏
InitPaymentRequestVm.java 100% 🍏
CapturePaymentResponseVm.java 100% 🍏
InitPaymentResponseVm.java 100% 🍏
PaymentService.java 96.25% -3.75% 🍏
OrderService.java 81.82% -4.04% 🍏
AbstractPaymentHandler.java 54.55% -45.45% ❌
PaypalHandler.java 11.63% -88.37% ❌
PaymentController.java 0% ❌

@khanhtrand khanhtrand marked this pull request as ready for review October 30, 2024 09:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'storefront-bff'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'backoffice-bff'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'sampledata'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'payment-paypal'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
75.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'storefront'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'media'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'customer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'rating'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'location'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'order'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'webhook'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'yas'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'payment'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'inventory'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'product'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'tax'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'promotion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed for 'search'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khanhtrand khanhtrand merged commit f3de565 into main Oct 31, 2024
55 checks passed
@khanhtrand khanhtrand deleted the feature/1003-payment-provider branch October 31, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhnguyenv1 danhnguyenv1 danhnguyenv1 approved these changes

@PhuocNguyenBa PhuocNguyenBa PhuocNguyenBa approved these changes

@nguyenvanhadncntt nguyenvanhadncntt nguyenvanhadncntt approved these changes

@thiennn thiennn Awaiting requested review from thiennn

Assignees
No one assigned
Labels
None yet
Projects
Yas's backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khanhtrand @nguyenvanhadncntt @PhuocNguyenBa @danhnguyenv1 @khanhtranduy