#1146 [Order] Common export csv file for basic table #1191
Conversation
nashtech-longlevanquoc1
force-pushed
the
#1146-Common-export-csv-file-for-basictable
branch
from
96d1fc4
to
2d76b93
Compare
Order Coverage Report
|
nashtech-longlevanquoc1
requested review from
khanhtrand,
nashtech-huyphamphu,
danhnguyenv1,
nashtech-diepnguyenngoc1 and
nguyenvanhadncntt
and removed request for
khanhtrand
|
|
||
| public class CsvExporter { | ||
|
|
||
| public static <T> byte[] exportToCsv(List<T> dataList, Class<T> clazz) throws IOException { |
There was a problem hiding this comment.
I think you should use CSV library (i.e opencsv). CSVWriter will help to escapes special characters like , \ in the content. In addition, please initialize Writer, ByteArrayOutputStream in try so they will be closed properly.
try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
CSVWriter writer = new CSVWriter(new OutputStreamWriter(baos))) {
|
|
||
| public static <T> byte[] exportToCsv(List<T> dataList, Class<T> clazz) throws IOException { | ||
| ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); | ||
| OutputStreamWriter writer = new OutputStreamWriter(byteArrayOutputStream, StandardCharsets.UTF_8); |
There was a problem hiding this comment.
Please close OutputStreamWriter in case Exception (consider using try-with-resources)
| for (Field field : fields) { | ||
| CsvColumn columnAnnotation = field.getAnnotation(CsvColumn.class); | ||
| if (columnAnnotation != null) { | ||
| writer.append(columnAnnotation.columnName()).append(","); |
There was a problem hiding this comment.
"A,B,C,"
Consider the unnecessary comma at the end of the sentence.
Should check for generate data below.
| try { | ||
| field.setAccessible(true); | ||
| Object value = field.get(data); | ||
| if (value instanceof List) { |
There was a problem hiding this comment.
Check value is null, will not be showing "null"
| } | ||
|
|
||
| public static <T> String createFileName(Class<T> clazz) { | ||
| DateTimeFormatter dateFormatter = DateTimeFormatter.ofPattern("dd-MM-yyyy"); |
There was a problem hiding this comment.
Should be "dd-MM-yyyy_HH-mm-ss" because there are a lot of files created in a day
| field.setAccessible(true); | ||
| Object value = field.get(data); | ||
| if (value instanceof List) { | ||
| writer.append(String.join(",", (List<String>) value)); |
There was a problem hiding this comment.
It should be considered in case of special characters.
nashtech-longlevanquoc1
changed the title
common-library/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.opencsv</groupId> | ||
| <artifactId>opencsv</artifactId> | ||
| <version>5.7.1</version> |
There was a problem hiding this comment.
Can you move the version to parent pom.xml?
<opencsv.version>5.7.1</opencsv.version>
| package com.yas.commonlibrary.csv; | ||
|
|
||
| public class BaseCsv { | ||
|
|
There was a problem hiding this comment.
I think at least we should have some common fields for this class , for example id. Then remove id in children classes
@CsvColumn(columnName = "id")
private Long id;
| DateTimeFormatter dateFormatter = DateTimeFormatter.ofPattern("dd-MM-yyyy_HH-mm-ss"); | ||
| String fromDate = LocalDateTime.now().format(dateFormatter); | ||
| CsvName csvName = clazz.getAnnotation(CsvName.class); | ||
| return csvName.fileName() + "_" + fromDate + ".csv"; |
There was a problem hiding this comment.
Just minor comment, use String.format instead of string concatenation
String.format("%s_%s.csv", csvName.fileName(), timestamp)
|
|
||
| public static <T> String createFileName(Class<T> clazz) { | ||
| DateTimeFormatter dateFormatter = DateTimeFormatter.ofPattern("dd-MM-yyyy_HH-mm-ss"); | ||
| String fromDate = LocalDateTime.now().format(dateFormatter); |
There was a problem hiding this comment.
Can you create a DateTimeUtils that will be used for other places?
`public class DateTimeUtils {
private static final String DEFAULT_PATTERN = "dd-MM-yyyy_HH-mm-ss";
public static String format(LocalDateTime dateTime) {
return format(dateTime, DEFAULT_PATTERN);
}
public static String format(LocalDateTime dateTime, String pattern) {
DateTimeFormatter formatter = DateTimeFormatter.ofPattern(pattern);
return dateTime.format(formatter);
}
}`
Storefront BFF Coverage Report
|
Recommendation Coverage Report
|
Media Coverage Report
|
Customer Coverage Report
|
Webhook Coverage Report
|
Inventory Coverage Report
|
Promotion Coverage Report
|
Rating Coverage Report
|
Location Coverage Report
|
Payment Paypal Coverage Report
|
Tax Coverage Report
|
Product Coverage Report
|
Cart Coverage Report
|
Search Coverage Report
|
Payment Coverage Report
|
nashtech-longlevanquoc1
force-pushed
the
#1146-Common-export-csv-file-for-basictable
branch
from
051da30
to
d8418f6
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
No description provided.