Feature/#1016 apply mapstruct for create checkout api #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hnd14
commented
Sep 11, 2024
hnd14
commented
- Resolved [Order/Checkout] Update Create Checkout feature to use MapStruct #1016 Update Create Checkout feature to use MapStruct
Order Coverage Report
|
nashtech-vietvuhoang1
requested review from
nashtech-tuannguyenhuu1 and
nashtech-vietvuhoang1
hnd14
force-pushed
the
feature/#1016-apply-mapstruct-for-create-checkout-api
branch
2 times, most recently
from
99558b5
to
bf71d44
Compare
|
API Call test |
hnd14
force-pushed
the
feature/#1016-apply-mapstruct-for-create-checkout-api
branch
2 times, most recently
from
c98c1b2
to
94d895d
Compare
nashtech-vietvuhoang1
approved these changes
Sep 12, 2024
nashtech-tuannguyenhuu1
approved these changes
Sep 13, 2024
| Checkout toModel(CheckoutPostVm checkoutPostVm); | ||
|
|
||
| @Mapping(target = "checkoutId", source = "checkoutId.id") | ||
| CheckoutItemVm toVm(CheckoutItem checkoutItem); |
There was a problem hiding this comment.
Please remove fromModel method in CheckoutItemVm class as it is not used anywhere.
hnd14
force-pushed
the
feature/#1016-apply-mapstruct-for-create-checkout-api
branch
from
94d895d
to
fcb6400
Compare
|
khanhtrand
deleted the
feature/#1016-apply-mapstruct-for-create-checkout-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.