Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wayland support #30

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Add wayland support #30

merged 3 commits into from
Feb 17, 2024

Conversation

SergioRibera
Copy link
Contributor

@SergioRibera SergioRibera commented Feb 15, 2024

If you use the library from wayland it is very likely that you will not get good results, with this PR I intend to solve that problem, I am using smithay because it is the easiest way to work with wayland and as a first integration I think it is great.

Important

The only thing that could be a problem is the definition of the raw_handler because wayland doesn't really offer an option for this, I have manipulated this to create a handler, but I don't think it will work completely.
And also to know if the monitor is primary or not, I have not seen how to get that information, but I imagine it is possible.

@nashaofu
Copy link
Owner

@SergioRibera
Copy link
Contributor Author

Ok, in a while I'll check the problem and upload a change

@SergioRibera
Copy link
Contributor Author

Problem solved, for some reason I had put the PartialEq

@nashaofu nashaofu merged commit aa87669 into nashaofu:master Feb 17, 2024
@nashaofu
Copy link
Owner

@SergioRibera is_primary has not been implemented

@SergioRibera
Copy link
Contributor Author

SergioRibera commented Feb 17, 2024

@nashaofu Yup, I didn't implement it because I couldn't find a way to get wayland to give me that information, if I find a way I'll do another PR. Although if you prefer I can make that the first element of the list is the primary one, I don't think that it applies in all the cases but it is what can be done for the moment

@nashaofu
Copy link
Owner

@nashaofu Yup, I didn't implement it because I couldn't find a way to get wayland to give me that information, if I find a way I'll do another PR. Although if you prefer I can make that the first element of the list is the primary one, I don't think that it applies in all the cases but it is what can be done for the moment

Maybe the coordinates of the primary display is 0,0

@SergioRibera
Copy link
Contributor Author

SergioRibera commented Feb 19, 2024

Maybe the coordinates of the primary display is 0,0

I think it would not apply in all cases, for example, my primary display is not at 0,0 because on the left I have my display

@nashaofu
Copy link
Owner

Get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants