Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utf-8 encoding specification to writing #124

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Add utf-8 encoding specification to writing #124

merged 2 commits into from
Nov 14, 2023

Conversation

bhyeh
Copy link
Contributor

@bhyeh bhyeh commented Mar 2, 2023

Issue #122 - added utf-8 encoding specification when writing report

@bhyeh bhyeh requested a review from ivanzvonkov March 2, 2023 15:11
@bhyeh bhyeh self-assigned this Mar 2, 2023
@bhyeh bhyeh linked an issue Mar 2, 2023 that may be closed by this pull request
@ivanzvonkov
Copy link
Contributor

Were you able to test this on a Windows machine?

@ivanzvonkov
Copy link
Contributor

FYI there are Windows tests that run in CI (only on main branch), so there could be a little test implemented to make sure this doesn't happen again but not absolutely necessary.

@bhyeh
Copy link
Contributor Author

bhyeh commented Mar 6, 2023

FYI there are Windows tests that run in CI (only on main branch), so there could be a little test implemented to make sure this doesn't happen again but not absolutely necessary.

Is this job in ci.yaml what you are referring to?

cross-platform-test:
name: cross-platform-test
if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags')
runs-on: ${{ matrix.os }}
env:
MPLBACKEND: Agg
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.7, 3.8, 3.9]
steps:
- uses: actions/checkout@v2
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install conda (Windows)
uses: conda-incubator/setup-miniconda@v2
with:
python-version: ${{ matrix.python-version }}
channels: conda-forge
channel-priority: strict
if: ${{ runner.os == 'Windows' }}
- name: Install conda dependencies (Windows)
run: |
conda install 'fiona>=1.5' 'rasterio>=1.2.6'
pip install -r requirements.txt
if: ${{ runner.os == 'Windows' }}
- name: Cache pip
uses: actions/cache@v2
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ hashFiles('requirements.txt') }}
restore-keys: |
${{ runner.os }}-pip-
${{ runner.os }}-
- name: Install dependencies
if: ${{ runner.os != 'Windows' }}
run: pip install -r requirements.txt
- name: Run tests (Windows)
if: ${{ runner.os == 'Windows' }}
env:
PROJ_LIB: C:\Miniconda\envs\test\Library\share\proj
GDAL_DATA: C:\Miniconda\envs\test\Library\share\gdal
run: python -m unittest discover -s tests
- name: Run tests
if: ${{ runner.os != 'Windows' }}
run: python -m unittest discover -s tests

@ivanzvonkov
Copy link
Contributor

Yes @bhyeh

@ivanzvonkov ivanzvonkov merged commit 1cb5fc7 into main Nov 14, 2023
4 checks passed
@ivanzvonkov ivanzvonkov deleted the codec_fix branch November 14, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows UnicodeEncodeError
2 participants