Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-13 - Fix timezone warning upon successful Sitemap creation and save #18

Merged
merged 7 commits into from
Jun 2, 2017

Conversation

sigee
Copy link
Collaborator

@sigee sigee commented May 29, 2017

No description provided.

@sigee sigee added the bug label May 29, 2017
@sigee sigee added this to the 1.6.0 milestone May 29, 2017
@sigee sigee requested a review from lewismc May 29, 2017 13:39
@sigee sigee assigned sigee and lewismc and unassigned sigee Jun 2, 2017
@lewismc
Copy link
Contributor

lewismc commented Jun 2, 2017

Thank you @sigee I will look at this tomorrow

Copy link
Contributor

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sigee i think this looks great.
Locally when I test it however, it does not seem to be picking up my PST datetime. It still defaults to UTC. I can verify this by generating a Sitemap... the time here was 09:54PST however the Sitemap time generated is displayed as 2017-06-02T16:54:08+00:00

<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9.xsd">
<!-- Created by Sitepod version 1.5.3 - For more information see https://github.com/nasa/sitepod -->
<!-- Last update of sitemap 2017-06-02T16:54:08+00:00 -->

@sigee
Copy link
Collaborator Author

sigee commented Jun 2, 2017

Hi @lewismc,
It is because when you use it locally, your IP address is 127.0.0.1 (localhost).
I mean $_SERVER['REMOTE_ADDR'] is not the IP address you are using on the internet.
It is just a guess, but maybe it helps if you try to open your local server trough internet.
See: https://whatismyipaddress.com/ and try to open your server on that ip address.
If it is still wrong, you need to upload it to a remote server.
I'm not sure why REMOTE_ADDR is wrong on localhost, but it is. I don't know any solution to fix this (maybe apache) issue.

@lewismc lewismc merged commit 3908272 into master Jun 2, 2017
@lewismc lewismc deleted the ISSUE-13 branch June 2, 2017 21:02
@lewismc
Copy link
Contributor

lewismc commented Jun 2, 2017

Got it @sigee thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants