Skip to content

sample_app Integration candidate: 2021-01-19 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 27, 2021
Merged

sample_app Integration candidate: 2021-01-19 #121

merged 7 commits into from
Jan 27, 2021

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jan 25, 2021 •
edited
Loading

Describe the contribution
Fix #101, Correct CFE_TBL_GetAddress return code check
Fix #115, Refactor UT_ClearForceFail to UT_ClearDefaultReturnValue
Fix #118, Create Security Policy

Testing performed
See https://github.com/nasa/cFS/pull/177/checks

Expected behavior changes

PR #119 - Documentation: Add Security.md with instructions on reporting vulnerabilities

PR #117 - Resolves bug where success code was reported as an error for CFE_TBL_GetAddress.

PR #116 - Rename UT_ClearForceFail as UT_ClearDefaultValue given change from nasa/osal#724

System(s) tested on
Ubuntu 18.04

Additional context
Part of nasa/cFS#177

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@ArielSAdamsNASA
@zanzaben
@skliper

@astrogeco astrogeco marked this pull request as ready for review January 27, 2021 00:48
@astrogeco astrogeco mentioned this pull request Jan 27, 2021
Merged
@astrogeco astrogeco merged commit 6e7cf88 into main Jan 27, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 27, 2021
@astrogeco
Integration Candidate 2021-01-19
d859dde 
Combines:
    nasa/cFE#1109
    nasa/osal#767
    nasa/PSP#243
    nasa/sample_app#121
    nasa/ci_lab#68
    nasa/to_lab#79
    nasa/sch_lab#62
    nasa/sample_lib#41
    nasa/tblCRCTool#29
    nasa/elf2cfetbl#65
    nasa/cFS-GroundSystem#150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a Security Policy Change UT_ClearForceFail to UT_ClearDefaultReturnValue Not correctly checking return code of CFE_TBL_GetAddress
3 participants
@astrogeco @zanzaben @arielswalker