updated adding instance_format to variable query #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckwondo
requested changes
Sep 3, 2024
Collaborator
chuckwondo
left a comment
chuckwondo
left a comment
There was a problem hiding this comment.
Hi @briannapagan. Thanks for opening this new PR. I made suggestions for supporting multiple instance format values, as allowed by the CMR.
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
frankinspace
approved these changes
Sep 4, 2024
Collaborator
Author
|
Changed thank you @chuckwondo ! |
chuckwondo
approved these changes
Sep 4, 2024
Collaborator
chuckwondo
left a comment
chuckwondo
left a comment
There was a problem hiding this comment.
Thanks @briannapagan (and @frankinspace)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the conversation here: #59
NASA GES DISC is releasing public zarr stores for specific variables of collections. The only way to discover what available zarr stores at variable level is via the CMR parameter instance_format. This simple PR adds this as a search parameter in VariablesQuery.
Closed last PR as it fell behind other commits: #60
Should encompass all feedback