Skip to content

Conversation

@teubert
Copy link
Collaborator

@teubert teubert commented Oct 19, 2021

A few proposed changes:

  1. For backwards compatibility, remove the atleast_1d- now a scalar returns a scalar and an array returns an array <- @MikeAndSpencer what do you think of this? Will it cause any problems
  2. Fix issue with thresholds_met equation
  3. Add an example
  4. Add tests
  5. Add a note to the template about using np functions over math
  6. Make thrown_object, circuit, and pneumatic_valve models compatible
  7. Update check to use np.isscalar

@teubert teubert added bug Something isn't working enhancement New feature or request labels Oct 19, 2021
@teubert teubert self-assigned this Oct 19, 2021
@teubert teubert added this to the v1.2 milestone Oct 19, 2021
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 1 alert when merging d8b680a into 38ff274 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 1 alert when merging 571d9c6 into 38ff274 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2021

This pull request introduces 1 alert when merging 10f9308 into 38ff274 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@MikeAndSpencer
Copy link
Collaborator

A few proposed changes:

  1. For backwards compatibility, remove the atleast_1d- now a scalar returns a scalar and an array returns an array <- @MikeAndSpencer what do you think of this? Will it cause any problems
  2. Fix issue with thresholds_met equation
  3. Add an example
  4. Add tests
  5. Add a note to the template about using np functions over math
  6. Make thrown_object, circuit, and pneumatic_valve models compatible
  7. Update check to use np.isscalar

@teubert I am good with getting rid of atleast_1d. It was something that Cason put in because of mismatched datatypes that he ran into when we were working on MCMC but it didn't affect the vectorization.

@teubert teubert merged commit 11f5fba into ng_to_nasa Oct 22, 2021
@teubert teubert deleted the nasa_to_ng_to_nasa branch October 22, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants