Decouple Thrown Object from Examples #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Some examples cannot be run alone as scripts because they're dependent on other examples. Since it's setup as a package imports have to be
from .[file_name] import [thing]in order to supportpython -m examples.[file_name]. However, this breaks when you run a file by itself from within examples directory (e.g., press run in IDE). For that to work the commandfrom [file_name] import [thing]is needed (without the period). Multiple users have had issues with thisSolution: remove the intra-package dependency by adding thrown_object to prog_models.models. Set it up to not be imported by default (not part of init.all), and update the examples to use this version instead of the version defined in examples.new_model
Closes #137