Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug: array and keys did not match in particle_filter #240

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

teubert
Copy link
Collaborator

@teubert teubert commented Aug 17, 2023

Changes from nasa/progpy#77

bug found and solution written by @mstraut

Solves issues where array values and keys do not match when 1. Do not call m.initialize(), and instead 2. provide a state as a dictionary instead of a state container, and 3. order the states in a different order than m.states

@teubert teubert added the bug Something isn't working label Aug 17, 2023
@github-actions
Copy link

Thank you for opening this PR. Since this is a release branch, the PR must complete the release checklist, below:

  • Check that each new feature has corresponding tests

  • Confirm all dependencies are in the following: requirements.txt, setup.py, the bottom of dev_guide.rst

  • Confirm that all issues associated with the release have been closed (i.e., requirements have been met) or assigned to another release

  • Run unit tests python -m tests

  • If present, run manual tests python -m tests.test_manual

  • Review the template(s)

  • Review static-analysis/linter results

  • Review the tutorial

  • Run and review the examples

  • Check that all examples are tested

  • Check new files in PR for any accidentally added

  • Check documents

    • Check that all desired examples are in docs

    • General review: see if any updates are required

  • Rebuild sphinx documents: sphinx-build sphinx_config/ docs/

  • Write release notes

  • Update version number in src/*/init.py and setup.py

  • For releases adding new features- ensure that NASA release process has been followed.

  • Confirm that on GitHub Releases page, the next release has been started and that a schedule is present including at least Release Date, Release Review Date, and Release Branch Opening Date.`

Copy link

@mstraut mstraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved it, but now I'm seeing tests fail when they didn't on my local

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice catch

@teubert teubert merged commit c423720 into release/v1.5.1 Aug 18, 2023
1 of 4 checks passed
@teubert teubert deleted the bug/pf_ordering branch August 18, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants