osal Integration candidate: 2021-04-06 #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure all headers have a consistent include guard and file block comment This gets all FSW code within src/os and src/bsp.
Ensure all headers have a consistent include guard and file block comment This gets all unit tests (function, not coverage) and ut assert
Scrub all include guards and file scope doxygen comments in src/unit-test-coverage
Filter out author and creation date info (not relevant)
The portable clock_gettime implementation had been using CLOCK_MONOTONIC to support its use as a PSP timebase for some platforms that used it this way. However with updates on the PSP side this is not required anymore. Preference should be to use CLOCK_REALTIME as it better aligns with the described semantics of the OSAL clock function, and makes for a better default. This can still be easily changed back if the user desires.
Rather than using a default name, use a specific name so that it can be polled more safely.
Fix #916, scrub include guards
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 8, 2021
Combines: nasa/cFE#1284 nasa/osal#951 nasa/PSP#289 Including: nasa/cFE#1251 - ES Info API Functional test nasa/osal#931 - Scrub include guards nasa/osal#937 - Switch to use CLOCK_REALTIME nasa/osal#938 - specify shell name in ShellOutputToFile nasa/PSP#286 - use OSAL timebase for CFE timers nasa/PSP#282 - modularize the ram, port, and eenasa/psp#om access nasa/PSP#285 - add psp module to implement timebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #931
Fix #916, scrub include guards
Replaces nonstandard header file block comments and include guards. No behavior changes
PR #937
Fix #844, switch to use CLOCK_REALTIME
Removes
CLOCK_MONOTONICas the osal colck source since PSP no longer needs it.OS_GetLocalTime()andOS_SetLocalTime()will work as described.PR #938
Fix #887, specify shell name in ShellOutputToFile
Replaces
shellNamewith a specificlocalShellNamethat can be polled safely and changes its type to a char ofOS_MAX_API_NAMElength for safety.Context
Part of nasa/cFS#238
Tests
osal checks https://github.com/nasa/osal/pull/951/checks
cFS bundle checks https://github.com/nasa/cFS/pull/238/checks