Fix #454, Better error translation on statvfs() #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
The statvfs() call depends on the underlying filesystem supporting this. On RTEMS, the IMFS filesystem type does not, and it returns the ENOSYS errno. This is better translated to OS_ERR_NOT_IMPLEMENTED rather than OS_ERROR.
jphickey
added
the
CCB:Ready
skliper
approved these changes
May 18, 2020
Contributor
|
CCB 20200520 - APPROVED |
skliper
added
CCB-20200520
and removed
CCB:Ready
astrogeco
added
CCB:Approved
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#355, Add global scope option to omit deprecated items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Map the ENOSYS errno to OS_ERR_NOT_IMPLEMENTED, which is more appropriate than OS_ERROR.
Fixes #454
Testing performed
Build and execute unit tests on RTEMS 4.11.3
Expected behavior changes
Unit test cases which use OS_statfs and run on an RTEMS IMFS volume (default for the root file system) will be skipped and categorized as "NA" due to OS_ERR_NOT_IMPLEMENTED response, rather than a failure.
System(s) tested on
RTEMS 4.11 on pc686 via QEMU
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.