Fix #374, Add Object Utility API functional tests #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
changed the title
astrogeco
reviewed
May 5, 2020
Contributor
astrogeco
left a comment
astrogeco
left a comment
There was a problem hiding this comment.
Can we default all text files to be .md instead of .txt?
Contributor
I'd recommend deleting the .txt file, doesn't add anything. |
yammajamma
force-pushed
the
fix374-2-Object-Utilities-Missing-Tests
branch
from
8fbea56 to
1822026
Compare
skliper
added
enhancement
CCB:Ready
skliper
force-pushed
the
fix374-2-Object-Utilities-Missing-Tests
branch
from
1822026 to
7d8d892
Compare
skliper
pushed a commit
to skliper/cFS
that referenced
this pull request
May 12, 2020
Contributor
|
Rebased for bundle CI testing with (mostly) IC branches (broken sample_app commit excluded, ut macro commit included). Bundle CI passes: https://travis-ci.com/github/skliper/cFS/builds/165460267 |
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
Contributor
|
CCB 20200513 - Discussed, will rebase and review offline (concept good) |
skliper
added
CCB-20200513
and removed
CCB:Ready
skliper
force-pushed
the
fix374-2-Object-Utilities-Missing-Tests
branch
from
7d8d892 to
8352d2f
Compare
Contributor
|
Rebased and ready for review |
skliper
approved these changes
May 13, 2020
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Add copyright header:
/*
*
* Copyright (c) 2020, United States government as represented by the
* administrator of the National Aeronautics Space Administration.
* All rights reserved. This software was created at NASA Goddard
* Space Flight Center pursuant to government contracts.
*
* This is governed by the NASA Open Source Agreement and may be used,
* distributed and modified only according to the terms of that agreement.
*
*/
Contributor
|
@jphickey can you take a look at this? |
jphickey
requested changes
May 19, 2020
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Only concern is the checking for specific values output from the ConvertToArrayIndex -- no assumption should be made about specific values in this context.
…ange between 0 and <MAX and output array indices vary
jphickey
approved these changes
May 22, 2020
skliper
approved these changes
May 22, 2020
astrogeco
added
IC-20200520
CCB:Approved
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#438: Set OSAL_SYSTEM_BSPTYPE for native builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #374, Object Utility API's missing functional test
Describe the contribution
Created missing functional tests for the OS_IdentifyObject, OS_ConvertToArrayIndex and OS_ForEachObject functions.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
System(s) tested on
cFS Dev Server
OS: Ubuntu 18.04
Versions: OSAL 5.0.11.0
**Contributor Info **
Yasir Khan
NASA GSFC