Fix #88, Add test for name too long and update comments

[dmknutsen]

Describe the contribution
Fixes #88, Add test for name too long and update comments.
Coverage test added to OS_TimerCreate for OS_ERR_NAME_TOO_LONG.
Updated comments related to sizing includes null terminator for:
OS_MAX_API_NAME, OS_MAX_PATH_LEN, OS_BUFFER_SIZE

Testing performed
Ran unit tests.

System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-19.10
Versions: cFE 6.7.11.0, OSAL 5.0.9.0, PSP 1.4.7.0

Contributor Info
Dan Knutsen
NASA/Goddard

[skliper]

Nitpick - could you update the commit message to stand alone? Something like:

Fix #88, Add test for name too long and update comments

Coverage test added to OS_TimerCreate for OS_ERR_NAME_TOO_LONG.
Updated comments related to sizing includes null terminator for:
OS_MAX_API_NAME, OS_MAX_PATH_LEN, OS_BUFFER_SIZE

[skliper]

Oh, and the issue description needs to explicitly say:
Fixes #88

This autolinks the pull request it with the issue.

[jphickey]

One issue noted in the code, also this needs to be coordinated/preemptively merged with the pull in #405

[jphickey]

Latest commit fa833b4 looks good, but still note that this will probably need to be manually merged/rebased with the changes in #405 which IIRC are already approved and should be in the next IC.

[astrogeco]

CCB 20200415 - APPROVED

[skliper]

Can we add a similar comment to OS_MAX_FILE_NAME or is it too late?

[skliper]

@dmknutsen @astrogeco actually, I can do the change in my commit... retracting previous comment.