Fix #15 unit test warnings #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qualify all pointers referring to string literals as `const` Eliminate unused local variables Add missing local function prototypes.
jphickey
force-pushed
the
fix-15-ut-warnings
branch
from
1b9301d to
ba82d52
Compare
Contributor
Author
|
Updated commit so it is based on the current |
skliper
approved these changes
Sep 18, 2019
skliper
added
the
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #15
constTesting performed
Rebuild OSAL per default configuration with unit tests enabled
Re-ran all unit tests and confirm passage
Expected behavior changes
No warnings generated when using `-Wall -Werror -std=c99 -pedantic -Wwrite-strings -Wstrict-prototypes'
System(s) tested on:
Ubuntu 18.04 (64-bit)
Contributor Info
Joseph Hickey, Vantage Systems, Inc.