Skip to content

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented May 18, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI + static analysis run

Expected behavior changes
None, just squashes static analysis warnings

System(s) tested on

  • Hardware: VM
  • OS: Ubuntu 18.04
  • Versions: Bundle main + apps + related static analysis resolution branches

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 18, 2022
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 18, 2022
@astrogeco
Copy link
Contributor

CCB:2022-05-18 APPROVED

@skliper skliper marked this pull request as ready for review May 24, 2022 15:43
astrogeco added a commit to nasa/cFS that referenced this pull request May 31, 2022
nasa/osal#1257, add rtems 6 support

Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Alan Cudmore <acudmore@users.noreply.github.com>
astrogeco added a commit to nasa/cFS that referenced this pull request May 31, 2022
*cFE v7.0.0-rc4+dev136* (nasa/cFE#2111)

- nasa/cFE#2105, Resolve static analysis warnings
- nasa/cFE#2108, cFE_Users_guide.pdf 404

*osal v6.0.0-rc4+dev83* (nasa/osal#1260)

- nasa/osal#1255, Resolve static analysis warnings
- nasa/osal#1257, add rtems 6 support

*psp v1.6.0-rc4+dev38* (nasa/PSP#346)

- nasa/PSP#344, Resolve uninit var static analysis warning

*elf2cfetbl v3.3.0-rc4+dev24* (nasa/elf2cfetbl#113)

- nasa/elf2cfetbl#112, Resolve uninit var static analysis warnings

*sch_lab v2.5.0-rc4+dev29* (nasa/sch_lab#116)

- nasa/sch_lab#115, Resolve uninit var static analysis warnings
@astrogeco astrogeco merged commit 4f2c16e into nasa:main May 31, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request May 31, 2022
**Combines**

*cFE v7.0.0-rc4+dev136* (nasa/cFE#2111)

- nasa/cFE#2108, cFE_Users_guide.pdf 404

*osal v6.0.0-rc4+dev83* (nasa/osal#1260)

- nasa/osal#1257, add rtems 6 support

*psp v1.6.0-rc4+dev38* (nasa/PSP#346)

*elf2cfetbl v3.3.0-rc4+dev24* (nasa/elf2cfetbl#113)

*sch_lab v2.5.0-rc4+dev29* (nasa/sch_lab#116)

*Resolve Static Analysis Warnings*

nasa/cFE#2105, Resolve static analysis warnings

nasa/osal#1255, Resolve static analysis warnings

nasa/PSP#344, Resolve uninit var static analysis warning

nasa/sch_lab#115, Resolve uninit var static analysis warnings

nasa/elf2cfetbl#112, Resolve uninit var static analysis warnings

Co-authored-by: Paul Ober <paulober@users.noreply.github.com>
Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Alan Cudmore <acudmore@users.noreply.github.com>
astrogeco added a commit to nasa/cFS that referenced this pull request May 31, 2022
**Combines**

*cFE v7.0.0-rc4+dev136* (nasa/cFE#2111)

- nasa/cFE#2108, cFE_Users_guide.pdf 404

*osal v6.0.0-rc4+dev83* (nasa/osal#1260)

- nasa/osal#1257, add rtems 6 support

*psp v1.6.0-rc4+dev38* (nasa/PSP#346)

*elf2cfetbl v3.3.0-rc4+dev24* (nasa/elf2cfetbl#113)

*sch_lab v2.5.0-rc4+dev29* (nasa/sch_lab#116)

*Resolve Static Analysis Warnings*

nasa/cFE#2105, Resolve static analysis warnings

nasa/osal#1255, Resolve static analysis warnings

nasa/PSP#344, Resolve uninit var static analysis warning

nasa/sch_lab#115, Resolve uninit var static analysis warnings

nasa/elf2cfetbl#112, Resolve uninit var static analysis warnings

Co-authored-by: Paul Ober <paulober@users.noreply.github.com>
Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Alan Cudmore <acudmore@users.noreply.github.com>
@skliper skliper added this to the Draco milestone Jul 20, 2022
@skliper skliper deleted the fix1253-ut_uninit_vars branch September 19, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB draco-rc2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant condition checks in UT Uninitialized variable static analysis warnings in unit tests

2 participants