Skip to content

Fix #1143, Regex update in coverage enforcement to match .0 #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix #1143, Regex update in coverage enforcement to match .0 #1144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/local_unit_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ jobs:
run: |
# Current best possible branch coverage is all but 4, with associated issues for each missing case
missed_branches=4
coverage_nums=$(grep -A 3 "Overall coverage rate" lcov_out.txt | grep branches | grep -oP "[1-9]+[0-9]*")
coverage_nums=$(grep -A 3 "Overall coverage rate" lcov_out.txt | grep branches | grep -oP "[0-9]+[0-9]*")

diff=$(echo $coverage_nums | awk '{ print $4 - $3 }')
if [ $(($diff > $missed_branches)) == 1 ]
if [ $diff -gt $missed_branches ]
then
grep -A 3 "Overall coverage rate" lcov_out.txt
echo "More than $missed_branches branches missed"
Expand Down