-
Notifications
You must be signed in to change notification settings - Fork 244
Labels
bugsecurityunit-testTickets related to the OSAL unit testing (functional and/or coverage)Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Description
Is your feature request related to a problem? Please describe.
CodeQL warning on line 72 (returning VecTbl):
osal/src/unit-test-coverage/ut-stubs/src/vxworks-intLib-stubs.c
Lines 51 to 77 in 09a2c5e
| OCS_VOIDFUNCPTR *OCS_INUM_TO_IVEC(unsigned int ui) | |
| { | |
| int32 Status = UT_DEFAULT_IMPL(OCS_INUM_TO_IVEC); | |
| OCS_VOIDFUNCPTR *VecTbl; | |
| OCS_VOIDFUNCPTR DummyVec; | |
| size_t VecTblSize; | |
| if (Status == 0) | |
| { | |
| UT_GetDataBuffer(UT_KEY(OCS_INUM_TO_IVEC), (void **)&VecTbl, &VecTblSize, NULL); | |
| if (VecTbl != NULL && ui < (VecTblSize / sizeof(OCS_VOIDFUNCPTR))) | |
| { | |
| VecTbl += ui; | |
| } | |
| else | |
| { | |
| DummyVec = &OCS_intLib_dummyfunc; | |
| VecTbl = &DummyVec; | |
| } | |
| } | |
| else | |
| { | |
| VecTbl = NULL; | |
| } | |
| return VecTbl; | |
| } |
Describe the solution you'd like
Make DummyVec static
Describe alternatives you've considered
Remove, no longer used in OSAL testing but could be used by PSP implementations. Leaving in for now.
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC
Metadata
Metadata
Assignees
Labels
bugsecurityunit-testTickets related to the OSAL unit testing (functional and/or coverage)Tickets related to the OSAL unit testing (functional and/or coverage)