Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to OSAL_OPAQUE_OBJECT_IDS and OSAL_ABSTRACT_FILESYS_TYPES #265

Closed
skliper opened this issue Oct 16, 2019 · 3 comments · Fixed by #404
Closed

Remove references to OSAL_OPAQUE_OBJECT_IDS and OSAL_ABSTRACT_FILESYS_TYPES #265

skliper opened this issue Oct 16, 2019 · 3 comments · Fixed by #404
Assignees
@jphickey
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Oct 16, 2019

Is your feature request related to a problem? Please describe.
References to removed #defines remain in the unit test code.

osal/src/unit-test-coverage/vxworks-ng/CMakeLists.txt

Lines 5 to 6 in ad88aa1

# This always uses OSAL_OPAQUE_OBJECT_IDS and OSAL_ABSTRACT_FILESYS_TYPES
add_definitions(-DOSAL_OPAQUE_OBJECT_IDS -DOSAL_ABSTRACT_FILESYS_TYPES)

Describe the solution you'd like
Remove references

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 5.1.0 milestone Oct 22, 2019
@waheedejaz
Copy link

Can I grab this issue?

@jphickey
Copy link
Contributor

Hold off on this one... in the fix for issue #312 (implemented but not yet in a pull request) refactored some of the same file where this appears so it was removed in the process.

@skliper skliper removed the good first issue Good for newcomers label Apr 10, 2020
@jphickey
Copy link
Contributor

Confirmed this is already fixed and merged in pull request #404, commit 4904591. There are no occurrences of either OSAL_OPAQUE_OBJECT_IDS or OSAL_ABSTRACT_FILESYS_TYPES in the current master branch.

@skliper skliper linked a pull request May 13, 2020 that will close this issue
Fix #261, #312, and #362, OSAL build cleanup (multiple issues) #404
Merged
jphickey added a commit to jphickey/osal that referenced this issue Aug 10, 2022
@jphickey
Fix nasa#265, name-based target configuration
8afeb2a 
Remove requirement to define a sequential/numbered list of targets.
Instead, user defines a list of target names, followed by a set of
properties associated with each name.

This makes it much simpler to consistently define CPUs but selectively
add/remove them from the build based on other criteria.
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#776 from jphickey/fix-265-name-based-target
aaa27b6 
Fix nasa#265, implement cmake name based targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #261, #312, and #362, OSAL build cleanup (multiple issues) jphickey/osal
3 participants
@jphickey @waheedejaz @skliper