-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Fault Management): allow fault providers to define shelve durations #7849
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7849 +/- ##
==========================================
- Coverage 57.43% 57.30% -0.13%
==========================================
Files 675 675
Lines 27317 27325 +8
Branches 2671 2673 +2
==========================================
- Hits 15689 15659 -30
- Misses 11292 11330 +38
Partials 336 336
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ozyx Can you add some testing instructions please? Code looks good.
Object.values(faults).forEach((selectedFault) => { | ||
this.openmct.faults.shelveFault(selectedFault, shelveData); | ||
}); | ||
await Promise.all( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
yep! will do |
@scottbell done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change. Very nice documentation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Closes #7853
Closes #5814
Describe your changes:
getShelveDurations()
to the Fault Management API that allows providers to define their own shelve durations. If no method is defined, a default list of shelve durations will be provided.codecov
npm package dependency as it has been deprecated for some time.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist