Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable perf/mem tests on PR + fix broken locator in imagery perf test #7806

Merged
merged 9 commits into from
Aug 13, 2024
Merged

chore: re-enable perf/mem tests on PR + fix broken locator in imagery perf test #7806

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b44e3c1
test: fix broken locator in imagery perf test
ozyx Aug 8, 2024
c0cac51
Prevent this from happening
unlikelyzero Aug 8, 2024
88268e3
make rule explicit
unlikelyzero Aug 8, 2024
049061e
test: maintain `locator()` pattern for contract tests
ozyx Aug 8, 2024
9aa1ea9
test(couchdb): try some new techniques to stabilize the test
ozyx Aug 10, 2024
4c2ba72
Revert "test(couchdb): try some new techniques to stabilize the test"
ozyx Aug 13, 2024
f646d87
chore: revert to `networkidle` and disable eslint rule
ozyx Aug 13, 2024
d4e11ee
test: add `@network` annotation for tests with real network requests
ozyx Aug 13, 2024
628857b
test: all `@network` tests are `@couchdb` tests
ozyx Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: revert to networkidle and disable eslint rule
  • Loading branch information
@ozyx
ozyx committed Aug 13, 2024
commit f646d8722b28c3009cd43e24725f3fb09acb04cb
26 changes: 16 additions & 10 deletions e2e/tests/functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@
This test suite is dedicated to tests which verify the basic operations surrounding Notebooks with CouchDB.
*/

/**
* Disable no-networkidle eslint rule until we can engineer more deterministic network-event
* driven tests.
*/
/* eslint-disable playwright/no-networkidle */

import { createDomainObjectWithDefaults } from '../../../../appActions.js';
import * as nbUtils from '../../../../helper/notebookUtils.js';
import { expect, test } from '../../../../pluginFixtures.js';
Expand All @@ -32,12 +38,12 @@ test.describe('Notebook Tests with CouchDB @couchdb', () => {
let testNotebook;

test.beforeEach(async ({ page }) => {
//Navigate to baseURL
await page.goto('./', { waitUntil: 'domcontentloaded' });
// Navigate to baseURL
await page.goto('./', { waitUntil: 'networkidle' });

// Create Notebook
testNotebook = await createDomainObjectWithDefaults(page, { type: 'Notebook' });
await page.goto(testNotebook.url, { waitUntil: 'domcontentloaded' });
await page.goto(testNotebook.url, { waitUntil: 'networkidle' });
});

test('Inspect Notebook Entry Network Requests', async ({ page }) => {
Expand All @@ -58,7 +64,7 @@ test.describe('Notebook Tests with CouchDB @couchdb', () => {
page.getByLabel('Add Page').click()
]);
// Ensures that there are no other network requests
await page.waitForLoadState('domcontentloaded');
await page.waitForLoadState('networkidle');

// Assert that only two requests are made
// Network Requests are:
Expand All @@ -77,7 +83,7 @@ test.describe('Notebook Tests with CouchDB @couchdb', () => {
// 2) The shared worker event from 👆 POST request
notebookElementsRequests = [];
await nbUtils.enterTextEntry(page, 'First Entry');
await page.waitForLoadState('domcontentloaded');
await page.waitForLoadState('networkidle');
expect(notebookElementsRequests.length).toBeLessThanOrEqual(2);

// Add some tags
Expand Down Expand Up @@ -141,7 +147,7 @@ test.describe('Notebook Tests with CouchDB @couchdb', () => {
// 4) The shared worker event from 👆 POST request
notebookElementsRequests = [];
await nbUtils.enterTextEntry(page, 'Fourth Entry');
page.waitForLoadState('domcontentloaded');
page.waitForLoadState('networkidle');

expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(4);

Expand All @@ -153,7 +159,7 @@ test.describe('Notebook Tests with CouchDB @couchdb', () => {
// 4) The shared worker event from 👆 POST request
notebookElementsRequests = [];
await nbUtils.enterTextEntry(page, 'Fifth Entry');
page.waitForLoadState('domcontentloaded');
page.waitForLoadState('networkidle');

expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(4);

Expand All @@ -164,7 +170,7 @@ test.describe('Notebook Tests with CouchDB @couchdb', () => {
// 4) The shared worker event from 👆 POST request
notebookElementsRequests = [];
await nbUtils.enterTextEntry(page, 'Sixth Entry');
page.waitForLoadState('domcontentloaded');
page.waitForLoadState('networkidle');

expect(filterNonFetchRequests(notebookElementsRequests).length).toBeLessThanOrEqual(4);
});
Expand Down Expand Up @@ -227,7 +233,7 @@ async function addTagAndAwaitNetwork(page, tagName) {
page.locator(`[aria-label="Autocomplete Options"] >> text=${tagName}`).click(),
expect(page.locator(`[aria-label="Tag"]:has-text("${tagName}")`)).toBeVisible()
]);
await page.waitForLoadState('domcontentloaded');
await page.waitForLoadState('networkidle');
}

/**
Expand All @@ -246,5 +252,5 @@ async function removeTagAndAwaitNetwork(page, tagName) {
)
]);
await expect(page.locator(`[aria-label="Tag"]:has-text("${tagName}")`)).toBeHidden();
await page.waitForLoadState('domcontentloaded');
await page.waitForLoadState('networkidle');
}