Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots correctly use configuration set on the parent if they can't their own #7770

Merged
merged 13 commits into from
Jul 16, 2024
Merged

Plots correctly use configuration set on the parent if they can't their own #7770

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
46b7268
For telemetry that cannot have it's own configuration, ensure that it…
shefalijoshi Jul 5, 2024
288c386
stacked plot test checks that config properties for immutable telemet…
shefalijoshi Jul 5, 2024
72fadad
add tab navigation to inspector tabs
unlikelyzero Jul 8, 2024
d2f2f61
add accessibility metadata to this component
unlikelyzero Jul 9, 2024
9116146
Update title to be on the correct component. Add expand/collapse logic
unlikelyzero Jul 9, 2024
0e74292
clean up test
unlikelyzero Jul 9, 2024
f293ec7
refactor: better a11y for plot forms, fix "expand by default" test, r…
ozyx Jul 12, 2024
b38fe41
a11y: aria label for plotOptionsItem
ozyx Jul 13, 2024
954b88c
refactor(a11y): PlotOptionsBrowse structure to have better a11y
ozyx Jul 13, 2024
dd7b475
fixed tests
unlikelyzero Jul 13, 2024
eab3d35
address comment
unlikelyzero Jul 13, 2024
3263957
reverted to match previous commit
unlikelyzero Jul 13, 2024
ce1443f
Merge branch 'master' into fix-stackedplots-config
ozyx Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up test
  • Loading branch information
@unlikelyzero
unlikelyzero committed Jul 9, 2024
commit 0e7429246c6a9e5cc8934d6b8210c04a872a1fc6
11 changes: 2 additions & 9 deletions e2e/tests/functional/plugins/plot/stackedPlot.e2e.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,7 @@ test.describe('Stacked Plot', () => {
).toContainText(swgC.name);
});

test.only('Changing properties of an immutable child plot are applied correctly', async ({
page
}) => {
test('Changing properties of an immutable child plot are applied correctly', async ({ page }) => {
await page.goto(stackedPlot.url);

// Go into edit mode
Expand All @@ -248,10 +246,8 @@ test.describe('Stacked Plot', () => {
// Expand config for the series
await page.getByLabel('Expand Sine Wave Generator').click();

// turn off alarm markers
// turn off alarm markers. Technically there should be a getBy locator to ensure we're selecting the correct alarm marker
await page.getByLabel('Alarm Markers').uncheck();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this should be a chained getBy locator to ensure we're selecting the correct alarm marker

//TODO We need to get it to the point that the following is the locator logic
// await page.getByRole('listitem', { name: 'Alarm Markers' }).getByRole('checkbox').uncheck();

// save
await page.getByRole('button', { name: 'Save' }).click();
Expand All @@ -268,14 +264,11 @@ test.describe('Stacked Plot', () => {
await page.getByLabel('Expand Sine Wave Generator').click();

// Assert that alarm markers are still turned off
//TODO We need to get it to the point that the following is the locator logic
// await await expect(page.getByRole('listitem', { name: 'Alarm Markers' }).getByRole('checkbox').not.toBeChecked();
await expect(
page
.getByTitle('Display markers visually denoting points in alarm.')
.getByRole('cell', { name: 'Disabled' })
).toBeVisible();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a chained locator which leverages Titles

// await expect(page.getByLabel('Inspector Views').getByRole('checkbox').nth(1)).not.toBeChecked();
});

test('the legend toggles between aggregate and per child', async ({ page }) => {
Expand Down
Loading