Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#6812): Align Plot and Plan X-Axes in Time Strips #7744

Merged
merged 26 commits into from
Jul 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5aa6a03
DRAFT - alignment for axes
shefalijoshi Jun 8, 2024
b240519
Use alignmentContext to manage tick widths instead of passing around …
shefalijoshi Jun 11, 2024
eff6398
Merge branch 'master' of https://github.com/nasa/openmct into alignme…
shefalijoshi Jun 11, 2024
c14960f
Remove log statements
shefalijoshi Jun 11, 2024
d2f7458
Add ability to remove alignment widths for a given y axis
shefalijoshi Jun 18, 2024
7e28e18
Fix computation of left margin and width of plan when in the timestrip
shefalijoshi Jun 20, 2024
2167eef
Remove excess padding when there is no left y axis
shefalijoshi Jun 20, 2024
bea3a92
Use alignment composable to adjust left margin and width of time syst…
shefalijoshi Jun 20, 2024
7ab7dc3
Fix now marker visibility
shefalijoshi Jun 20, 2024
8e15ba2
refactor: use built in `Map()` data structure
ozyx Jun 24, 2024
ae90491
refactor: improve readability and conciseness
ozyx Jun 24, 2024
ee1a322
docs: improve jsdocs
ozyx Jun 24, 2024
8f5e2ed
refactor: move jsdoc typedefs to bottom of file
ozyx Jun 24, 2024
78e5ec9
refactor: axis to use vue reactivity
ozyx Jun 25, 2024
81e66fc
fix: return alignment as an object of refs
ozyx Jun 26, 2024
63ac403
alignmentMap needs to be shared state, move it out of the useAlignmen…
shefalijoshi Jun 26, 2024
a096829
Merge branch 'alignment-composable' of https://github.com/nasa/openmc…
shefalijoshi Jun 26, 2024
8288570
Fix now marker offset
shefalijoshi Jul 1, 2024
c76c339
Merge branch 'master' of https://github.com/nasa/openmct into alignme…
shefalijoshi Jul 2, 2024
2029b93
Add new visual test for time strips
shefalijoshi Jul 5, 2024
5b51761
Merge branch 'master' of https://github.com/nasa/openmct into alignme…
unlikelyzero Jul 17, 2024
7b13022
update with animation stabilization
unlikelyzero Jul 17, 2024
467d5c8
Fix failing test due to changed injected property (path -> objectPath)
shefalijoshi Jul 22, 2024
68fdd6d
change injected property from path to objectPath
shefalijoshi Jul 22, 2024
99c1657
Fix spelling
shefalijoshi Jul 22, 2024
548533f
Remove unused arguments to function call
shefalijoshi Jul 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add new visual test for time strips
  • Loading branch information
shefalijoshi committed Jul 5, 2024
commit 2029b9342e61287556b9f331a5e171a025333e4b
62 changes: 62 additions & 0 deletions e2e/tests/visual-a11y/planning-timestrip.visual.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
/*****************************************************************************
* Open MCT, Copyright (c) 2014-2024, United States Government
* as represented by the Administrator of the National Aeronautics and Space
* Administration. All rights reserved.
*
* Open MCT is licensed under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0.
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
* Open MCT includes source code licensed under additional open source
* licenses. See the Open Source Licenses file (LICENSES.md) included with
* this source code distribution or the Licensing information page available
* at runtime from the About dialog for additional information.
*****************************************************************************/

import percySnapshot from '@percy/playwright';
import fs from 'fs';

import { createDomainObjectWithDefaults, createPlanFromJSON } from '../../appActions.js';
import { scanForA11yViolations, test } from '../../avpFixtures.js';
import { VISUAL_FIXED_URL } from '../../constants.js';
import { setBoundsToSpanAllActivities } from '../../helper/planningUtils.js';

const examplePlanSmall2 = JSON.parse(
fs.readFileSync(new URL('../../test-data/examplePlans/ExamplePlan_Small2.json', import.meta.url))
);

test.describe('Visual - Time Strip @a11y', () => {
test.beforeEach(async ({ page }) => {
await page.goto(VISUAL_FIXED_URL, { waitUntil: 'domcontentloaded' });
});
test('Time Strip View', async ({ page, theme }) => {
const timeStrip = await createDomainObjectWithDefaults(page, {
type: 'Time Strip',
name: 'Time Strip Visual Test'
});
await createPlanFromJSON(page, {
json: examplePlanSmall2,
parent: timeStrip.uuid
});
await createDomainObjectWithDefaults(page, {
type: 'Sine Wave Generator',
parent: timeStrip.uuid
});
await page.goto(VISUAL_FIXED_URL, { waitUntil: 'domcontentloaded' });

await setBoundsToSpanAllActivities(page, examplePlanSmall2, timeStrip.url);

await percySnapshot(page, `Time Strip View (theme: ${theme}) - With SWG and Plan`);
});
});

test.afterEach(async ({ page }, testInfo) => {
await scanForA11yViolations(page, testInfo.title);
});
Loading